Conversation
Contributor
WASM runtime size check:Compared to target branchMoonbase runtime: 2272 KB (no changes) ✅ Moonbeam runtime: 2248 KB (no changes) ✅ Moonriver runtime: 2240 KB (no changes) ✅ Compared to latest release (runtime-3400)Moonbase runtime: 2272 KB (+244 KB compared to latest release) Moonbeam runtime: 2248 KB (+236 KB compared to latest release) Moonriver runtime: 2240 KB (+228 KB compared to latest release) |
Contributor
Coverage Report@@ Coverage Diff @@
## master rq/fix-treasury-spend-origin +/- ##
================================================================
+ Coverage 74.47% 74.59% +0.12%
Files 377 377
+ Lines 95720 96033 +313
================================================================
+ Hits 71283 71632 +349
- Misses 24437 24401 -36
|
pLabarta
approved these changes
Jan 15, 2025
Contributor
pLabarta
left a comment
There was a problem hiding this comment.
New tests look good. Failing CI is due to guidelines, the branding guidelines site, being down and probably in process of being updated; should be safe to ignore.
TarekkMA
approved these changes
Jan 16, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Following the upgrade to the Polkadot SDK stable2407 (see Update moonbeam to polkadot stable2407 by gonzamontiel · Pull Request #2932 · moonbeam-foundation/moonbeam), a regression was introduced in the runtime that breaks the existing Treasury spending proposal flow (as described here).
Following the upgrade to RT3300, it is not possible anymore to create a Treasury spending proposal:
The proposed correction is to create a
RootOrTreasuryCouncilOriginorigin (to be configured as SpendOrigin on the Treasury pallet).