Conversation
Contributor
Coverage Report@@ Coverage Diff @@
## master elois-async-moonriver +/- ##
========================================================
Coverage 73.06% 73.06% 0.00%
Files 228 228
Lines 69944 69944
========================================================
Hits 51103 51103
Misses 18841 18841
|
Agusrodri
previously approved these changes
Apr 22, 2024
RomarQ
previously approved these changes
Apr 22, 2024
ahmadkaouk
previously approved these changes
Apr 22, 2024
Co-authored-by: Ahmad Kaouk <56095276+ahmadkaouk@users.noreply.github.com>
2799584
RomarQ
approved these changes
May 16, 2024
ahmadkaouk
approved these changes
May 16, 2024
Agusrodri
approved these changes
May 16, 2024
This was referenced May 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Enable asynchrnous backing on moonriver:
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?