Skip to content

Enable async backing on moonriver#2776

Merged
RomarQ merged 4 commits intomasterfrom
elois-async-moonriver
May 16, 2024
Merged

Enable async backing on moonriver#2776
RomarQ merged 4 commits intomasterfrom
elois-async-moonriver

Conversation

@librelois
Copy link
Copy Markdown
Collaborator

What does it do?

Enable asynchrnous backing on moonriver:

  • Add pallet async_backing for moonriver runtime
  • Add migration PalletStakingMultiplyRoundLenBy2 for moonriver runtime
  • Use relay chain slot instead of parachain block number for staking round clock

What important points reviewers should know?

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?

What value does it bring to the blockchain users?

@librelois librelois requested review from Agusrodri and RomarQ April 22, 2024 10:56
@librelois librelois added B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed. breaking Needs to be mentioned in breaking changes labels Apr 22, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 22, 2024

Coverage Report

@@                   Coverage Diff                    @@
##           master   elois-async-moonriver     +/-   ##
========================================================
  Coverage   73.06%                  73.06%   0.00%     
  Files         228                     228             
  Lines       69944                   69944             
========================================================
  Hits        51103                   51103             
  Misses      18841                   18841             
Files Changed Coverage

Coverage generated Thu May 16 14:39:20 UTC 2024

@librelois librelois marked this pull request as ready for review April 22, 2024 12:32
Agusrodri
Agusrodri previously approved these changes Apr 22, 2024
RomarQ
RomarQ previously approved these changes Apr 22, 2024
ahmadkaouk
ahmadkaouk previously approved these changes Apr 22, 2024
Co-authored-by: Ahmad Kaouk <56095276+ahmadkaouk@users.noreply.github.com>
@RomarQ RomarQ dismissed stale reviews from ahmadkaouk, Agusrodri, and themself via 2799584 May 16, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

B7-runtimenoteworthy Changes should be noted in any runtime-upgrade release notes breaking Needs to be mentioned in breaking changes D5-nicetohaveaudit⚠️ PR contains trivial changes to logic that should be properly reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants