Closed
Conversation
ahmadkaouk
added
B7-runtimenoteworthy
Contributor
Coverage Report@@ Coverage Diff @@
## master ahmad-fix-refund-external-cost +/- ##
==================================================================
+ Coverage 72.46% 72.79% +0.33%
- Files 229 228 -1
- Lines 70512 70206 -306
==================================================================
+ Hits 51094 51105 +11
- Misses 19418 19101 -317
|
RomarQ
approved these changes
Apr 10, 2024
Contributor
|
Closing. The frontier fork was updated in #2745 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Fixes
refund_external_costwhich is not working because the current implementation creates a temporary copy of weight_info and applies changes to it, resulting in changes not being saved.Frontier PR: polkadot-evm/frontier#1377
What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?