Conversation
nanocryk
added
A0-pleasereview
crystalin
approved these changes
Feb 24, 2022
| pub struct GenerateAccountKey { | ||
| /// Generate 12 words mnemonic instead of 24 | ||
| #[structopt(long, short = "w")] | ||
| #[clap(long, short = 'w')] |
Collaborator
There was a problem hiding this comment.
Why is it changing format for single/double quote ?
Contributor
Author
There was a problem hiding this comment.
Must be char literal instead of string literal now (change from structopt to clap v3)
| /// Channels for manual xcm messages (downward, hrmp) | ||
| pub xcm_senders: Option<(flume::Sender<Vec<u8>>, flume::Sender<(ParaId, Vec<u8>)>)>, | ||
| /// Ethereum data access overrides. | ||
| pub overrides: Arc<OverrideHandle<Block>>, |
Collaborator
There was a problem hiding this comment.
What is this "overrides" ?
Contributor
Author
There was a problem hiding this comment.
It the storage/schema overrides. Moved from parameters to member of FullDeps struct as part of the async cache change.
I tried to stay similar to the frontier template for that part.
crystalin
added
A8-mergeoncegreen
notlesh
added
D1-audited👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Upstream Substrate changes : paritytech/substrate@polkadot-v0.9.16...polkadot-v0.9.17
structoptreplaced byclapv3 (use clap3 instead of structopt paritytech/substrate#10632)No need to cherrypick the hardcoded
runtime_cache_sizesince the issue is fixed in cumulus.Upstream Polkadot changes : paritytech/polkadot@release-v0.9.16...release-v0.9.17
ParentIsDefault=>ParentIsPreset: RemoveDefaultbound onAccountIdtypes under the xcm directory paritytech/polkadot#4712Upstream Cumulus changes : paritytech/cumulus@polkadot-v0.9.16...master
(no dedicated 0.9.17 branch when making the PR)
Nimbus changes : moonbeam-foundation/nimbus@moonbeam-polkadot-v0.9.16...moonbeam-polkadot-v0.9.17
ORML changes : moonbeam-foundation/open-runtime-module-library@moonbeam-polkadot-v0.9.16...moonbeam-polkadot-v0.9.17
Frontier changes
@tgmichel made
moonbeam-polkadot-v0.9.17branch from upstreammasterto sync with all upstream changes, since it updated recently to a recent substrate.What important points reviewers should know?
Is there something left for follow-up PRs?
What alternative implementations were considered?
Are there relevant PRs or issues in other repositories (Substrate, Polkadot, Frontier, Cumulus)?
What value does it bring to the blockchain users?