Skip to content

Update XCM SDK docs for ethersSigner to evmSigner changes#747

Merged
eshaben merged 7 commits intomasterfrom
eshaben/allow-viem-client
Sep 21, 2023
Merged

Update XCM SDK docs for ethersSigner to evmSigner changes#747
eshaben merged 7 commits intomasterfrom
eshaben/allow-viem-client

Conversation

@eshaben
Copy link
Copy Markdown
Contributor

@eshaben eshaben commented Sep 15, 2023

Description

This PR is an extension of #746. It makes some minor formatting and variable name changes and it also adds a local way to create a signer with viem for consistency (as thats what we did with ethers).

Checklist

  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira
  • If this page requires a disclaimer, I have added one

After Translation Requirements

  • No additional PRs are required after the translations are done

@eshaben eshaben added the A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) label Sep 15, 2023
Copy link
Copy Markdown
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@eshaben eshaben merged commit a841350 into master Sep 21, 2023
@eshaben eshaben deleted the eshaben/allow-viem-client branch September 21, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants