add destinationFeeBalance property in the response examples#727
Merged
eshaben merged 1 commit intomoonbeam-foundation:eshaben/add-destinationFeeBalancefrom Aug 29, 2023
Conversation
Contributor
|
Thanks @mmaurello!! Merging this into a local branch to update the reference page |
99a115a
into
moonbeam-foundation:eshaben/add-destinationFeeBalance
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After the new changes deployed to the XCM-SDK, in which we return a new property
destinationFeeBalance, we have to add the property in the example responses in the docsThe property
destinationFeeBalanceis useful when the asset paying for the fees in the destination chain is different from the asset being transferred and/or the asset paying for the fees in the source chain.Example: sending WBTC from HydraDX to Moonbeam:
The property
destinationFeeBalancehelps controlling that the sender has enough GLMR in their HydraDX account.Checklist
moonbeam-docs-cnrepo, I have created a ticket for the translations in Jiramoonbeam-mkdocsto update redirectsmove-pages.pyscript to move the pages and update the image paths on the chinese repomoonbeam-docs-cncompress-images.pyscript to compress the images.moonbeam-docs-cnrepo to use the new variablesCorresponding PRs
moonbeam-foundation/xcm-sdk#127
After Translation Requirements
moonbeam-docsrepo to remove imagesmoonbeam-docsrepo to remove variablesmoonbeam-mkdocsrepo to add redirects for Chinese siteItems to be Updated
Please list any of the items that will need to be added or deleted after the translations are done here.