Skip to content

fix: Bug fixes in firefox file walk #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2023
Merged

fix: Bug fixes in firefox file walk #229

merged 2 commits into from
Jul 10, 2023

Conversation

@a-urth
Copy link
Contributor

@a-urth a-urth commented Jul 7, 2023

  • fix panic in case browser data error
  • ignore files walk error in firefox, since it will be returned if at least one invocation of file walk function returns error
  • use WalkDir instead of Walk since its faster
  • simplify logic a bit in firefox browser init

@moonD4rk moonD4rk self-assigned this Jul 10, 2023
@moonD4rk moonD4rk added bug Something isn't working enhancement New feature or request labels Jul 10, 2023
@moonD4rk moonD4rk self-requested a review July 10, 2023 03:37
@moonD4rk moonD4rk changed the title Bug fixes Fix: Bug fixes in firefox file walk Jul 10, 2023
@moonD4rk moonD4rk changed the title Fix: Bug fixes in firefox file walk fix: Bug fixes in firefox file walk Jul 10, 2023
@moonD4rk moonD4rk merged commit ab4d3e1 into moonD4rk:master Jul 10, 2023
@moonD4rk
Copy link
Owner

moonD4rk commented Jul 10, 2023

LGTM, Thx!

@moonD4rk moonD4rk removed their request for review July 11, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@moonD4rk moonD4rk

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@a-urth @moonD4rk