Skip to content

fix(uno): Ensure that the canvas' context is active when rendering#2559

Merged
mattleibow merged 1 commit intomono:mainfrom
unoplatform:dev/jela/multi-gl-fix
Aug 17, 2023
Merged

fix(uno): Ensure that the canvas' context is active when rendering#2559
mattleibow merged 1 commit intomono:mainfrom
unoplatform:dev/jela/multi-gl-fix

Conversation

@jeromelaban
Copy link
Contributor

@jeromelaban jeromelaban commented Aug 17, 2023 •
edited
Loading

Description of Change

Ensures the that the GL context is current when rendering for a given SKSwapChainPanel, allowing for multiple instances to be rendered correctly in an app.

Bugs Fixed

API Changes

None.

Behavioral Changes

None.

Required skia PR

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Merged related skia PRs
  • Changes adhere to coding standard
  • Updated documentation

@mattleibow mattleibow added the backport/release/2.x Backport this PR to release/2.x label Aug 17, 2023
@mattleibow mattleibow merged commit d5bcfdf into mono:main Aug 17, 2023
@github-actions github-actions bot mentioned this pull request Aug 17, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Aug 17, 2023
@jeromelaban @github-actions
fix(uno): Ensure that the canvas' context is active when rendering (#…
5813bc7 
…2559)

(cherry picked from commit d5bcfdf)
@mattleibow mattleibow added the backport/release/2.88.4-preview Backport this PR to release/2.88.4-preview label Aug 17, 2023
@github-actions github-actions bot mentioned this pull request Aug 17, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Aug 17, 2023
@jeromelaban @github-actions
fix(uno): Ensure that the canvas' context is active when rendering (#…
0db6d6c 
…2559)

(cherry picked from commit d5bcfdf)
mattleibow pushed a commit that referenced this pull request Aug 18, 2023
@github-actions @jeromelaban
fix(uno): Ensure that the canvas' context is active when rendering (#…
01e0fcb 
…2559) (#2560)

(cherry picked from commit d5bcfdf)

Co-authored-by: Jérôme Laban <jerome.laban@nventive.com>
mattleibow pushed a commit that referenced this pull request Aug 18, 2023
@github-actions @jeromelaban
fix(uno): Ensure that the canvas' context is active when rendering (#…
d5c3b7b 
…2559) (#2561)

(cherry picked from commit d5bcfdf)

Co-authored-by: Jérôme Laban <jerome.laban@nventive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattleibow mattleibow mattleibow approved these changes

Assignees

No one assigned

Labels

backport/release/2.x Backport this PR to release/2.x backport/release/2.88.4-preview Backport this PR to release/2.88.4-preview

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] SKSwapChainPanel - Only the last created instance renders in Uno WASM

2 participants

@jeromelaban @mattleibow