Skip to content

Conversation

@xargom
Copy link
Collaborator

@xargom xargom commented Nov 19, 2025

Description

Replaces all mentions of TLS1_0 and 1_1 for 1_2 and 1_3

Link to any related issue(s): DOCSP-54400

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals I have added appropriate changelog entries.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

@xargom xargom requested a review from a team as a code owner November 19, 2025 22:07
@github-actions
Copy link
Contributor

APIx bot: a message has been sent to Docs Slack channel

Copy link

@jromo-mdb jromo-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xargom xargom requested a review from a team as a code owner November 19, 2025 23:02
Copy link
Collaborator

@marcosuma marcosuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - can you sync with @marcabreracast as she's working on the PR to release support for TLS1.3 on Terraform - we should release both PRs more or less at the same time

@marcabreracast marcabreracast mentioned this pull request Nov 21, 2025
13 tasks
@github-actions
Copy link
Contributor

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

@github-actions github-actions bot added the stale label Nov 27, 2025
@marcabreracast marcabreracast added not_stale Not stale issue or PR and removed stale labels Nov 28, 2025
Copilot AI review requested due to automatic review settings November 28, 2025 13:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the MongoDB Atlas Terraform provider documentation and API specifications to remove support for deprecated TLS versions 1.0 and 1.1, retaining only TLS 1.2 and 1.3 as valid options for cluster configurations.

Key Changes:

  • Removed TLS1_0 and TLS1_1 from enum values in API specification files
  • Updated test configurations to use TLS1_2 instead of TLS1_1
  • Updated all documentation files to reflect the supported TLS versions (1.2 and 1.3 only)

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tools/codegen/atlasapispec/raw-multi-version-api-spec.yml Removed TLS1_0 and TLS1_1 from minimumEnabledTlsProtocol enum definitions in three locations
tools/codegen/atlasapispec/multi-version-api-spec.flattened.yml Removed TLS1_0 and TLS1_1 from minimumEnabledTlsProtocol enum definitions in flattened spec
internal/testutil/acc/advanced_cluster_mig_TPF_test.go Updated test configurations from TLS1_1 to TLS1_2
docs/resources/cluster.md Updated documentation to list only TLS1_2 and TLS1_3 as valid values
docs/resources/advanced_cluster.md Updated documentation to list only TLS1_2 and TLS1_3 as valid values
docs/data-sources/clusters.md Updated documentation to list only TLS1_2 and TLS1_3 as valid values
docs/data-sources/cluster.md Updated documentation to list only TLS1_2 and TLS1_3 as valid values
docs/data-sources/advanced_clusters.md Updated documentation to list only TLS1_2 and TLS1_3 as valid values
docs/data-sources/advanced_cluster.md Updated documentation to list only TLS1_2 and TLS1_3 as valid values

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@marcabreracast
Copy link
Collaborator

Did a merge from master to make sure that PR #3912 does not cause any issues.
FYI @xargom, merging this PR now so both PRs are merged at the same time. Thank you! Feel free to resolve the associated DOCSP ticket.

@marcabreracast marcabreracast merged commit bb10fe4 into master Nov 28, 2025
49 checks passed
@marcabreracast marcabreracast deleted the DOCSP-54400 branch November 28, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not_stale Not stale issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants