Skip to content

DRIVERS-1709: Convert legacy transactions spec tests to unified test format #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 55 commits into from
Feb 14, 2024
Merged

DRIVERS-1709: Convert legacy transactions spec tests to unified test format #1502

merged 55 commits into from
Feb 14, 2024

Conversation

@jmikola
Copy link
Member

@jmikola jmikola commented Feb 1, 2024 •
edited
Loading

https://jira.mongodb.org/browse/DRIVERS-1709
https://jira.mongodb.org/browse/DRIVERS-2834

Note: withTransaction tests will be ported in a separate PR: #1505

Please complete the following before merging:

  • Update changelog.
  • Make sure there are generated JSON files from the YAML test files.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, sharded
    clusters, and serverless).

POC: mongodb/mongo-php-library#1226

@jmikola jmikola mentioned this pull request Feb 1, 2024
Merged
@jmikola jmikola force-pushed the drivers-1709 branch 5 times, most recently from e3d13c3 to ca46be1 Compare February 5, 2024 22:07
@jmikola jmikola marked this pull request as ready for review February 5, 2024 22:11
@jmikola jmikola requested a review from a team as a code owner February 5, 2024 22:11
@jmikola jmikola requested review from durran and removed request for a team February 5, 2024 22:11
@jmikola jmikola force-pushed the drivers-1709 branch 3 times, most recently from 6b6ba3d to 38293cc Compare February 7, 2024 16:30
@jmikola jmikola requested review from a team as code owners February 7, 2024 16:53
@jmikola jmikola requested review from dariakp and katcharov and removed request for a team February 7, 2024 16:53
jmikola added a commit to jmikola/mongo-php-library that referenced this pull request Feb 7, 2024
@jmikola
wip Sync converted transaction spec tests
3ad8843 
POC for mongodb/specifications#1502
@jmikola jmikola requested review from alcaeus and removed request for dariakp and katcharov February 7, 2024 17:19
@jmikola jmikola force-pushed the drivers-1709 branch 2 times, most recently from b7191e9 to 583e24d Compare February 7, 2024 18:44
jmikola added a commit to jmikola/mongo-php-library that referenced this pull request Feb 7, 2024
@jmikola
wip Sync converted transaction spec tests
fcb73e6 
POC for mongodb/specifications#1502
@jmikola jmikola mentioned this pull request Feb 7, 2024
Merged
4 tasks
jyemin
jyemin reviewed Feb 7, 2024
View reviewed changes
Copy link
Contributor

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I have these running in the Java driver. A few failures running on sharded clusters that Jeremy is aware of, but otherwise looking good.

jmikola added 18 commits February 12, 2024 10:07
@jmikola
causal-consistency.yml
9b65ca4
@jmikola
bulk.yml
a46724d
@jmikola
abort.yml
1d1672e
@jmikola
mongos-pin-auto-tests.py and mongos-pin-auto.yml
ecda108
@jmikola
Reorder top-level fields
ea4905e
@jmikola
Consolidate $$unsetOrMatches
cf9d577
@jmikola
Consolidate document objects
7810637
@jmikola
Consolidate $$exists
88318f6
@jmikola
Consolidate $$sessionLsid
6332420
@jmikola
Consolidate $numberLong
833905b
@jmikola
Consolidate configureFailPoint times option
a607f7d
@jmikola
Move legacy test format docs to separate file
3d8eeed
@jmikola
Remove unused session1 entities
6b87951
@jmikola
Consolidate forbid_serverless using test-level runOnRequirements
4974021 
These files were originally split off in DRIVERS-2713 since the legacy format only allowed top-level requirements.
@jmikola
Use int|long for all getMore cursor ID type checking
881845b
@jmikola
Consolidate $$type
d6838fa
@jmikola
Use lowercase read preference mode strings
492be89
@jmikola
Generate JSON files
19d4785
@jmikola jmikola requested a review from a team as a code owner February 12, 2024 20:15
@jyemin jyemin self-requested a review February 12, 2024 23:32
jyemin
jyemin approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@jyemin jyemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmikola jmikola requested a review from durran February 13, 2024 01:28
@jmikola
Copy link
Member Author

jmikola commented Feb 13, 2024

Note: following a discussion in Slack, I created DRIVERS-2834 and added a separate commit to exclude load-balanced topologies in tests using targetedFailPoint.

I just updated the PHPLIB patch build in mongodb/mongo-php-library#1226 and @jyemin shared a passing Java build with me prior to leaving his LGTM above.

Pending another review from @durran, I'll consider this good to merge.

durran
durran approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node tests are all passing, but hanging since we've got a leak in our runner (we skipped all the txn unified tests in lb mode previously) - so LGTM.

alcaeus
alcaeus approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the pre-commit checks aren't happy though. The failing build contains instructions on how to fix them.

@jmikola jmikola merged commit a7696bc into master Feb 14, 2024
@jmikola jmikola deleted the drivers-1709 branch February 14, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@durran durran durran approved these changes

@alcaeus alcaeus alcaeus approved these changes

@jyemin jyemin jyemin approved these changes

Assignees

@durran durran

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jmikola @durran @alcaeus @jyemin