chore(NODE-5822): sync CSOT spec tests and setup prose stubs #3962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/integration/client-side-operations-timeout/client_side_operations_timeout.unit.test.ts
Show resolved
Hide resolved
nbbeeken
added
the
Primary Review
aditi-khare-mongoDB
previously approved these changes
Jan 11, 2024
Contributor
|
All failing CI tests are flaky tests or data lake (which currently always fails) |
W-A-James
added
Team Review
W-A-James
suggested changes
Jan 11, 2024
Contributor
W-A-James
left a comment
W-A-James
left a comment
There was a problem hiding this comment.
When we file the follow-up tickets, can we add TODOs to these test files where relevant that reference the respective ticket?
test/integration/client-side-operations-timeout/client_side_operations_timeout.prose.test.ts
Show resolved
Hide resolved
W-A-James
approved these changes
Jan 11, 2024
W-A-James
approved these changes
Jan 11, 2024
durran
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Is there new documentation needed for these changes?
None
What is the motivation for this change?
Stubbing out the tests will remove a major portion of the diff as we're able to start enabling them
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript