DRIVERS-3300: Implement returnStoredSource in $vectorSearch#1896
Open
paulinevos wants to merge 1 commit into
Open
DRIVERS-3300: Implement returnStoredSource in $vectorSearch#1896paulinevos wants to merge 1 commit into
returnStoredSource in $vectorSearch#1896paulinevos wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Implements support for the returnStoredSource option on the $vectorSearch aggregation stage within the PHP builder, aligning stage construction and encoding with the updated spec and adding coverage for the new option.
Changes:
- Added
returnStoredSourceas an optional boolean argument/property for$vectorSearchstage encoding. - Updated the stage factory and fluent factory helpers to accept/pass through
returnStoredSource. - Added a new pipeline fixture and test case validating
returnStoredSource: trueoutput.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Builder/Stage/VectorSearchStageTest.php | Adds a new test covering $vectorSearch with returnStoredSource: true. |
| tests/Builder/Stage/Pipelines.php | Updates vector search doc links and adds a stored-source pipeline fixture. |
| src/Builder/Stage/VectorSearchStage.php | Extends the stage operator to include and serialize returnStoredSource. |
| src/Builder/Stage/FluentFactoryTrait.php | Adds returnStoredSource to the fluent vectorSearch() helper and forwards it. |
| src/Builder/Stage/FactoryTrait.php | Adds returnStoredSource to the static vectorSearch() factory and forwards it. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2.x #1896 +/- ##
============================================
- Coverage 87.72% 87.69% -0.03%
Complexity 3328 3328
============================================
Files 454 454
Lines 6656 6657 +1
============================================
- Hits 5839 5838 -1
- Misses 817 819 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on mongodb/mql-specifications#38
Fixes PHPLIB-1763