[LG-5684] fix(rich-links): update colors for RichLinkBadge component #3283
+47
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephl3
requested review from
TheSonOfThomp,
adamrasheed and
Copilot
and removed request for
a team
🦋 Changeset detectedLatest commit: 842d6bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the color palette for the RichLinkBadge component to improve contrast and visibility in dark mode. The changes ensure that badges maintain proper contrast ratios by using darker backgrounds with lighter text/icon colors, and properly propagates dark mode context through the component tree.
Key Changes:
- Updated dark mode badge colors to use darker backgrounds (
gray.dark2,blue.dark3) with lighter text/icons for better contrast - Wrapped
RichLinkcomponent withLeafyGreenProviderto ensure dark mode context propagates to child components - Added Storybook decorator to enable dark mode toggling in stories
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
chat/rich-links/src/RichLink/RichLinkBadge/RichLinkBadge.styles.ts |
Updated color palette values for dark mode badges to improve contrast |
chat/rich-links/src/RichLink/RichLink.tsx |
Wrapped component with LeafyGreenProvider and removed redundant darkMode props from child components |
chat/rich-links/src/RichLink/RichLink.stories.tsx |
Added darkMode control and decorator for testing dark mode in Storybook |
.changeset/kind-goats-pump.md |
Documented changes for release notes |
|
Size Change: +1.53 kB (+0.08%) Total Size: 1.8 MB
ℹ️ View Unchanged
|
|
Coverage after merging steph/chat-rich-links-darkmode into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
adamrasheed
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
Updates the color palette used by the
RichLinkBadgecomponent to improve contrast and visibility, particularly in dark mode. The component now uses darker background colors and lighter text/icon colors for better readability. Additionally, wrapsRichLinkwithLeafyGreenProviderto ensure proper dark mode context propagation to child components.🎟️ Jira ticket: LG-5684
✅ Checklist
pnpm changesetand documented my changes🧪 How to test changes
Composition/Chat/RichLink)gray.dark2background withgray.light1icons andgray.light2textblue.dark3background withblue.light2icons/textMessage.Linkscomponent