Skip to content

feat(NODE-7334): remove ByteUtils and NumberUtils from the onDemand ns #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baileympearson merged 1 commit into from
Jan 15, 2026
Merged

feat(NODE-7334): remove ByteUtils and NumberUtils from the onDemand ns #859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/parser/on_demand/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import { ByteUtils } from '../../utils/byte_utils';
import { NumberUtils } from '../../utils/number_utils';
import { type BSONElement, parseToElements } from './parse_to_elements';
/**
* @experimental
Expand All @@ -11,10 +9,6 @@ export type OnDemand = {
parseToElements: (this: void, bytes: Uint8Array, startOffset?: number) => Iterable<BSONElement>;
// Types
BSONElement: BSONElement;

// Utils
ByteUtils: ByteUtils;
NumberUtils: NumberUtils;
};

/**
Expand All @@ -24,8 +18,6 @@ export type OnDemand = {
const onDemand: OnDemand = Object.create(null);

onDemand.parseToElements = parseToElements;
onDemand.ByteUtils = ByteUtils;
onDemand.NumberUtils = NumberUtils;

Object.freeze(onDemand);

Expand Down
2 changes: 1 addition & 1 deletion test/node/bson_binary_vector.spec.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import * as path from 'path';
import { BSON, BSONError, Binary, EJSON } from '../register-bson';
import { expect } from 'chai';

const { toHex, fromHex } = BSON.onDemand.ByteUtils;
const { toHex, fromHex } = BSON.ByteUtils;

type VectorHexType = '0x03' | '0x27' | '0x10';
type VectorTest = {
Expand Down
Loading