Conversation
nbbeeken
previously approved these changes
Jan 13, 2025
Contributor
nbbeeken
left a comment
There was a problem hiding this comment.
LGTM, but some new issue has cropped up in latest. I imagine this would repro on main if we just re-ran the latest task so its external, can you just confirm and capture the issue in a ticket?
Should we skip latest here to keep the CI green?
Contributor
Author
I confirmed on main and added NODE-6662. I'll skip here when back on Wednesday - we also still need mongodb-labs/drivers-evergreen-tools#573 to go in first so I can remove the direct clone from that branch here as well. |
nbbeeken
reviewed
Jan 15, 2025
nbbeeken
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pins NPM to 10 with Node.js 18.
What is changing?
Updates dependency script to ensure the pinning.
Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-6634
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript