fix(NODE-5578): improve objectId deserialisation by skipping buffer allocation#615
Closed
billouboq wants to merge 1 commit intomongodb:mainfrom
Closed
fix(NODE-5578): improve objectId deserialisation by skipping buffer allocation#615billouboq wants to merge 1 commit intomongodb:mainfrom
billouboq wants to merge 1 commit intomongodb:mainfrom
Conversation
5 tasks
Contributor
|
Hi @billouboq, thanks so much for this PR. Taking a look in the debugger, with this change, the |
Contributor
Author
|
Yeah no problem @W-A-James , I can understand. Thanks for the heads up 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve ObjectId deserialisation by around 20% by skipping one buffer allocation.
Also add a benchmark that deserialise lot's of ObjectIds
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript