Skip to content

fix(NODE-3021): fix a long standing bug in Decimal128.fromString() #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dariakp merged 2 commits into from
Sep 9, 2021
Merged

fix(NODE-3021): fix a long standing bug in Decimal128.fromString() #458

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0854e3f
Fix a long standing bug in Decimal128.fromString()
tzhuan Sep 8, 2021
70fefa5
Add more test cases for leading/trailing zeros
tzhuan Sep 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/decimal128.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ export class Decimal128 {
lastDigit = nDigitsStored - 1;
significantDigits = nDigits;
if (significantDigits !== 1) {
while (representation[firstNonZero + significantDigits - 1] === '0') {
while (digits[firstNonZero + significantDigits - 1] === 0) {
significantDigits = significantDigits - 1;
}
}
Expand Down
2 changes: 2 additions & 0 deletions test/node/decimal128_tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1210,6 +1210,8 @@ describe('Decimal128', function () {
expect(new Decimal128('00').toString()).to.equal('0');
expect(new Decimal128('0.5').toString()).to.equal('0.5');
expect(new Decimal128('-0.5').toString()).to.equal('-0.5');
expect(new Decimal128('-0.0097').toString()).to.equal('-0.0097');
expect(new Decimal128('-0.0011').toString()).to.equal('-0.0011');
expect(new Decimal128('-1e400').toString()).to.equal('-1E+400');
done();
});
Expand Down