Feature/multiple private registry secrets#1339
Merged
Merged
Conversation
Contributor
Member
|
Summary Adds support for configuring multiple private registry pull secrets via a new privateRegistriesPullSecretRefs field. This is useful when registry credentials are managed by different teams or external secret operators (e.g., External Secrets, Vault). Changes API:
Implementation:
Example spec:
scanner:
privateRegistriesPullSecretRefs:
- name: team-a-registry-creds
- name: team-b-registry-creds
- name: external-secrets-managed-credsBackward Compatibility
|
Member
|
Implementation Approach Change The previous implementation used an init container with a shell script to merge Docker configs at pod startup. This has been replaced with operator-side merging: The operator approach is simpler and more robust - pods remain unchanged regardless of how many source secrets are configured. |
31b7f9b to
d3f6811
Compare
Co-Authored-By: Christoph Hartmann <chris@lollyrock.com>
d3f6811 to
e76b523
Compare
e76b523 to
787faf8
Compare
chris-rock
approved these changes
Feb 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Support for multiple imagepullsecrets for the operator container scan
add test scenario in makefile to host 2 "private" registries locally, to test with local k3s (via k3d)
before mounting the secret to the pod, we add an init container that merges multiple secrets into a single docker-config.json with multiple auths