🧹 remove admission controller#1336
Merged
Merged
Conversation
chris-rock
force-pushed
the
chris-rock/remove-admission-controller
branch
from
d91cb72 to
50b9a79
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
This comment has been minimized.
This comment has been minimized.
Member
|
If we're going to remove this we need to think through how this would work since the integration includes the setup |
Member
Author
|
We just remove the flag in the integration, has not been used anyway. |
chris-rock
force-pushed
the
chris-rock/remove-admission-controller
branch
from
e633c7e to
be905c1
Compare
chris-rock
force-pushed
the
chris-rock/remove-admission-controller
branch
from
258f757 to
5c90930
Compare
- Add DeprecatedAdmission and DeprecatedCertificateProvisioning types to CRD to accept existing configs with admission settings without errors - Add cleanupOrphanedAdmissionResources() to automatically remove leftover admission resources (webhook, deployment, service, secret) - Update migration guide with automatic cleanup documentation This ensures smooth upgrades from versions that had admission webhooks enabled. The deprecated admission field is ignored but accepted, and any orphaned resources are automatically cleaned up.
chris-rock
force-pushed
the
chris-rock/remove-admission-controller
branch
from
5c90930 to
1561316
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why Was Admission Scanning Removed?
The admission controller was removed to simplify the operator and reduce operational complexity:
TLS Certificate Management: The admission webhook required managing TLS certificates, either through cert-manager or OpenShift's service serving certificates. This added significant operational burden.
Pipeline-Based Scanning Is More Effective: Policy enforcement belongs in the CI/CD pipeline, before workloads are deployed. This provides faster feedback to developers and prevents policy violations earlier in the development cycle.
Reduced Attack Surface: Removing the webhook reduces the operator's attack surface and eliminates a potential point of failure in the Kubernetes API server request path.