Draft: Run styles #1268
Open
Draft: Run styles #1268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Might find time to review at some point but probably not until all 0.10.0 work is done on my end, which will probs come down to the wire |
Panzerhandschuh
force-pushed
the
feat/run-styles
branch
from
0099227 to
e158a84
Compare
Panzerhandschuh
force-pushed
the
feat/run-styles
branch
from
e158a84 to
6d37156
Compare
Comment on lines
+14
to
+16
| [G.CLIMB_MOM, [S.NORMAL, S.NO_TELEPORT]], | ||
| [G.CLIMB_KZT, [S.NORMAL, S.NO_TELEPORT]], | ||
| [G.CLIMB_16, [S.NORMAL, S.NO_TELEPORT]], |
Member
There was a problem hiding this comment.
non TP should be the default, and TP be a style.
But we should discuss this more
Member
Author
There was a problem hiding this comment.
Agreed, I'll change this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #205
I'm opening this up for early review, but we don't need to merge this until after 0.10 releases. TAS, segmented, and easy (low grav, slowmo) run styles still need further discussion.
Screenshots (if applicable)
Checks
./create-migration.sh <name>and committed the migration if I've made DB schema changesfeat: Add foo,chore: Update bar, etc...fixuped into my original commits