Lazily initialize and enable the LFU filter #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not initialize the LFU filter (`FrequencySketch`) at the cache creation time. Initialize and enable it once the cache gets half full.
Ensure to use the latest entry counts when initializing the filter.
Fix some errors on calculating the entry count.
Enhance unit tests for weight-based cache management.
Remove unnecessary `pub(crate)`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR for #24.
This PR makes these caches not to initialize the LFU filter (
FrequencySketch) at the cache creation time, but initialize and enable it once the cache is half full (based on the weighted size).The size of the
FrequencySketchis determined by the followings:weigheris set, use the current number of the entries in the cache.max_capacityof the cache, which is equals to the max number of entries.This PR also changes the
max_capacityfromusizetou64.