Webhooks with URL's that contain query parameters#160
Merged
eric merged 2 commits intomojombo:masterfrom Mar 3, 2014
Merged
Conversation
Collaborator
|
Thanks for noticing (and fixing this). I appreciate the tests, too. |
eric
added a commit
that referenced
this pull request
Mar 3, 2014
Webhooks with URL's that contain query parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed that Webhooks with URL's that contain query parameters were not being correctly handled (in the cause of providing an API key for example).
This PR fixes that and a small typo in the message that is displayed when a webhook failed.
Thanks,
Ash.