Use spotless / palantirJavaFormat - 2.56.0 for all JDKs#634
Merged
slawekjaranowski merged 1 commit intomasterfrom Jun 13, 2025
Merged
Use spotless / palantirJavaFormat - 2.56.0 for all JDKs#634slawekjaranowski merged 1 commit intomasterfrom
slawekjaranowski merged 1 commit intomasterfrom
Conversation
slawekjaranowski
force-pushed
the
use-version-for-plutin
branch
from
68e4702 to
335f685
Compare
Member
Author
|
@slachiewicz we have similar change as in Maven parent |
Spotless start using palantir-java-format 2.57.0 on Java 21 - on older jdks different versions are used. It causes a different code format depends on using JDK references: - diffplug/spotless#2447 - diffplug/spotless#2503 - palantir/palantir-java-format#1320 Additionally, we can't use older spotless on JDK8
slawekjaranowski
force-pushed
the
use-version-for-plutin
branch
from
335f685 to
4bdba1c
Compare
slachiewicz
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotless start using palantir-java-format 2.57.0 on Java 21 - on older jdks different versions are used.
It causes a different code format depends on using JDK
references:
Additionally, we can't use older spotless on JDK8
As issue - diffplug/spotless#2503 was closed, reverting spotless plugin to older version is not a resoultion.