fix: use helm chart's built-in router instead of separate NBRoutingPeer#921
Open
kirgene wants to merge 1 commit intofeature/storage-clusterfrom
Open
fix: use helm chart's built-in router instead of separate NBRoutingPeer#921kirgene wants to merge 1 commit intofeature/storage-clusterfrom
kirgene wants to merge 1 commit intofeature/storage-clusterfrom
Conversation
The separate NBRoutingPeer CRD wasn't setting up network routers properly. Switch to helm chart's built-in router which handles this automatically.
kirgene
requested review from
PaulGregoryBaker,
bushjames,
dfry,
elnyry-sam-k,
kalinkrustev,
shashi165,
sijo5722-2021 and
vijayg10
as code owners
dfry
reviewed
Feb 11, 2026
Contributor
dfry
left a comment
dfry
left a comment
There was a problem hiding this comment.
I need to review this onprem to confirm routing issue
kirgene
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
NBRoutingPeerwas created separately to support custom tolerations, but the helm chart'srouteralready supports this natively. Replaced it by enablingrouter.enabledwith the appropriate tolerations, removing the need for a standalone resource.