Skip to content

Auth error handling with status codes #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 14, 2025
Merged

Auth error handling with status codes #841

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dfbf006
Refactor authentication error handling to use serror::Result and stat…
MP-Tool Sep 11, 2025
b7b9580
Refactor error messages
MP-Tool Sep 12, 2025
6dd9048
Refactor authentication error handling to include status codes and im…
MP-Tool Sep 14, 2025
81ca3ee
clean up
MP-Tool Sep 14, 2025
100acb8
clean
MP-Tool Sep 14, 2025
2295660
fmt
MP-Tool Sep 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions bin/core/src/api/auth.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@ use derive_variants::{EnumVariants, ExtractVariant};
use komodo_client::{api::auth::*, entities::user::User};
use resolver_api::Resolve;
use response::Response;
use reqwest::StatusCode;
use serde::{Deserialize, Serialize};
use serde_json::json;
use serror::Json;
use serror::{Json, AddStatusCode};
use typeshare::typeshare;
use uuid::Uuid;

Expand Down Expand Up @@ -152,7 +153,9 @@ impl Resolve<AuthArgs> for GetUser {
self,
AuthArgs { headers }: &AuthArgs,
) -> serror::Result<User> {
let user_id = get_user_id_from_headers(headers).await?;
let user_id = get_user_id_from_headers(headers)
.await
.status_code(StatusCode::UNAUTHORIZED)?;
Ok(get_user(&user_id).await?)
Copy link
Member

@mbecker20 mbecker20 Sep 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Ok(get_user(&user_id).await?)
get_user(&user_id).await.status_code(StatusCode::UNAUTHORIZED)

Copy link
Contributor Author

@MP-Tool MP-Tool Sep 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

@mbecker20 mbecker20 Sep 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-check, this is on get_user. Currently it will 500 if it can't find user at id.

}
}