Improve login form #788
Merged
Improve login form #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackra1n
commented
Aug 30, 2025
| ); | ||
| } | ||
|
|
||
| if (isLoading && !user) return null; |
There was a problem hiding this comment.
this caused the login page to re-render on switching tabs which resulted in reset input fields
There was a problem hiding this comment.
I think removing this might cause the login screen to "flash" every refresh, since there will be a render where user has not loaded yet but the user has localstorage token
There was a problem hiding this comment.
Yeah I just verified this behavior from this change
mbecker20
reviewed
Sep 1, 2025
|
|
||
| if (isLoading && !user) return null; | ||
|
|
||
| if (!user || error) return <Login />; |
There was a problem hiding this comment.
This suggestion should fix
Suggested change
| if (!user || error) return <Login />; | |
| if (error) return <Login />; | |
| if (!user) return null; |
mbecker20
approved these changes
Sep 1, 2025
mbecker20
added a commit
that referenced
this pull request
Sep 1, 2025
* 1.19.2-dev-0 * deploy 1.19.2-dev-1 * Add option to make run command detachable (#766) * improve missing files log to include the missing paths * bump mungos for urlencoding mongo creds * Update permissioning.md - typo: "priviledges" -> "privileges" (#770) * Add support for monaco-yaml and docker compose spec validatiaon (#772) * deploy 1.19.2-dev-2 * on delete user, remove from all user groups * fix Google login issues around `picture` * unsafe_unsanitized_startup_config * improve git provider support re #355 * should fix #468 * should fix exit code re #597 * deploy 1.19.2-dev-3 * fix container ports sorting (#776) * missing serde default * deploy 1.19.2-dev-4 * ensure git tokens trimmed in remote url * Add link to Authentik support docs * Fix incorrect commit branch when using linked repo re #634 * Better display container port ranges (#786) * ensure build and sync also commit to correct branch. re #634 * deploy 1.19.2-dev-5 * Improve login form (#788) * Use proper form for login, add autocomplete and names to input fields * Do not return null if loading * Remove unused function * Cleanup and streamline * improve login screen flash on reload * first builder given same name as first server * 1.19.2 --------- Co-authored-by: mbecker20 <[email protected]> Co-authored-by: Brian Bradley <[email protected]> Co-authored-by: Ravi Wolter-Krishan <[email protected]> Co-authored-by: Christopher Hoage <[email protected]> Co-authored-by: jack <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #403
and maybe #652 but I couldn't reproduce everything from that issue so unsure. I tested with iOS, safari and bitwarden, protonpass
this PR improves the login page form implementation. Main changes are replacing local state for credentials with native form submission and improving accessability. I also looked at https://www.chromium.org/developers/design-documents/create-amazing-password-forms/ for some tips.
also removed the unused
WithLoadingcomponent fromutil.tsx(i couldnt find any other references of it)