Dynamic manager path in setup

[henninghh990]

Added MODX_MANAGER_URL to the setup options, so that "Files are already in-place" is checkable on sites where manager/ has been renamed.

What does it do?

The function on the first page of the setup checks if the manager/-folder exists, and let's the user check "Files are already in-place". I've replaced the string manager/ with MODX_MANAGER_URL so it reads the dynamic value from config.inc.php.

Why is it needed?

Many of us rename the manager/-page to either customize the experience or for security purposes. This fix enables us to install / upgrade a site and select "Files are already in-place".

How to test

Rename manager and manager URL in config.inc.php, then run setup.

[opengeek]

You can already achieve the ability to customize the manager path/url using the advanced distribution, along with several other paths/urls. I don't see the need for this in the standard distribution.

[smg6511]

Agree with @opengeek here. I've also changed the manager folder name on some sites; in the case where you don't use the advanced dist for an initial site install you can simply manually change the manager path in config.inc.php when renaming the manager folder. That change won't be overwritten on future upgrade installs.

Though having a convenience method for doing this might be nice, it probably encourages the idea that security-by-obscurity is effective—which I believe many if not most would agree it is not.