Capture stdout stderr when running shell commands in quiet mode #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example usage: `stack-pr submit` returned with exit 1 due to an outdated version of `gh`. ``` $ stack-pr submit Adding cross-links to PRs Exitcode: 1 Stdout: None Stderr: GraphQL: Projects (classic) is being deprecated in favor of the new Projects experience, see: https://github.blog/changelog/2024-05-23-sunset-notice-projects-classic/. (repository.pullRequest.projectCards) subprocess.CalledProcessError: Command '['gh', 'pr', 'edit', 'modularml/modular#70936', '-t', 'Test GH', '-F', '-', '-B', 'main']' returned non-zero exit status 1. ``` Test Plan: ``` python -m pytest tests/test_shell_commands.py -v ```
langong347
force-pushed
the
lang/print_stderrout
branch
from
c4fcdb2 to
819482d
Compare
langong347
changed the title
atomicapple0
approved these changes
Oct 22, 2025
|
@zbowling @ZolotukhinM May I get your approval for this PR? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved
run_shell_command()to capture stdout and stderr when in quiet mode instead of suppressing them. This ensures errors and warnings are always visible for debugging.Example usage:
stack-pr submitreturned with exit 1 due to an outdated version ofgh.Test plan