Open
Conversation
|
This PR actually fixes a lot of JavaScript issues, can it be merged please? |
Member
|
There's a failing test and a few dubious changes, but I'm sure it can be brought to shape. @lorenzomorandini would you care to review & test the code? |
|
Ok, I will review it |
|
I've been trying this version for a few days and all javascript problems seem to have gone:
|
Member
|
Update: I'm working on a test suite for JS using selenium, once I am able to anchor all feature and reproduce the issues mentioned here, I this it will reduce the risk when merging this PR. |
aatrubilin
added a commit
to aatrubilin/django-advanced-filters
that referenced
this pull request
Apr 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGES:
every time the add rule button was pressed.
perfectly).
'isfalse' (Also the value field becomes a readonly field, in these cases).
This was creating some issues and I thought it was a useless feature to keep in so I get rid of
that part.
and this corrected some bugs (for example: now range operator works properly).
sense to re-initiate the first rule (this problem was forcing you to use always an equal operator as
your first rule) .
'iexact' operator.