Open
Conversation
This commit changes the way the URLs are declared to avoid RemovedInDjango110Warning messages. The old way, using django.conf.urls.patterns(), is deprecated and will be removed in Django 1.10
| var value = input.val(); | ||
| $.get(choices_url, function(data) { | ||
| if (value) { | ||
| data.results.push({'id': value, 'text': value}) |
Member
There was a problem hiding this comment.
Wouldn't the currently selected value already exist in the results? This does feel redundant, as you mentioned.
Contributor
Author
There was a problem hiding this comment.
The value actually might not exist in the results. One example is choices being disabled for a field. To avoid duplication though, there should be a check to see if the value is currently in data. No reason to add it if it is already there.
Member
There was a problem hiding this comment.
Good point. In that case, how about we add the value into results only if it does not exist already ?
Member
|
I just merged master into this branch locally and tested it out. Things seem to work as promised:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge request allows the select2 widget to pre-populate with the current value. It should also fix Issue 22.
There is a side effect to how I fixed this, which I think is OK. If the value is not in the list returned by the ajax call it is added to the beginning of the list. This does also make it easy to switch back to the old value if you want to.
Also, if the value is in the list returned from the ajax call, it is in the list twice. This behavior is less desired, but it can be useful if you have a long list to see what the previous value was.