Conversation
asfaltboy
left a comment
There was a problem hiding this comment.
My apologies for slow response. Thanks for this PR, I do think it makes sense.
I think we can take it a step further and just remove simplejson entirely now. I say this because it seems we only used simplejson to support python 2.7/3.3, as per their docs:
simplejson exposes an API familiar to users of the standard library marshal and pickle modules. It is the externally maintained version of the json library, but maintains compatibility with the latest Python 3.8+ releases back to Python 3.3 as well as the legacy Python 2.5 - Python 2.7 releases.
Before we apply merge the change, though, could we add a test case or two to advanced_filters/tests/test_q_serializer.py which ensure serialising and unserialising date and datetime values work?
|
Hi, Thanks for your response. I am a bit busy now. Will swing back to this PR soon.
I also think
Sure gimme some time |
|
Hi, sorry i forgot about this PR. #182 (review) has been addressed. Please take a look. |
Update setup.py
Closes #181