-
Notifications
You must be signed in to change notification settings - Fork 176
Fix syntax errors in ModelicaReference documentation snippets #4275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
henrikt-ma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
beutlich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tobolar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is also
y = <strong>if abs</strong>(x) < Modelica.Constants.eps...
in ModelicaReference.Classes.'function' to be fixed similarly.
|
Btw. there are sometimes used spaces beneath the equal sign: |
Fixed.
Fixed these anyway. |
tobolar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Well, this is can be seen as a doc-fix and not as a new feature. Can you resolve the merge conflict as well? Thanks. |
06c8ba0 to
f852a50
Compare
The wiki page says: "no new PRs can be opened" But if I was the project leader I would accept stuff like this regardless :)
Done. |
f852a50 to
aae206b
Compare
|
@casella can you please review the changes .Thankyou |
Fix syntax errors in ModelicaReference documentation snippets
No description provided.