Skip to content

Conversation

@maltelenz
Copy link
Contributor

No description provided.

Copy link
Contributor

@henrikt-ma henrikt-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@beutlich beutlich added L: ModelicaReference Issue addresses ModelicaReference documentation Issue addresses the documentation labels Jan 22, 2024
Copy link
Member

@beutlich beutlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tobolar tobolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also

y = <strong>if abs</strong>(x) &lt; Modelica.Constants.eps...

in ModelicaReference.Classes.'function' to be fixed similarly.

@tobolar
Copy link
Contributor

tobolar commented Jan 22, 2024

Btw. there are sometimes used spaces beneath the equal sign: = and :=. But sometimes not.
(Which this PR is not about)

@maltelenz
Copy link
Contributor Author

There is also

y = <strong>if abs</strong>(x) &lt; Modelica.Constants.eps...

in ModelicaReference.Classes.'function' to be fixed similarly.

Fixed.

Btw. there are sometimes used spaces beneath the equal sign: = and :=. But sometimes not. (Which this PR is not about)

Fixed these anyway.

Copy link
Contributor

@tobolar tobolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@maltelenz
Copy link
Contributor Author

@casella Since we are past the cutoff date for 4.1.0, I assume this should technically go in after the branching?

I'll leave this as is for @casella to decide when to push the merge button.

@beutlich
Copy link
Member

@casella Since we are past the cutoff date for 4.1.0, I assume this should technically go in after the branching?

I'll leave this as is for @casella to decide when to push the merge button.

Well, this is can be seen as a doc-fix and not as a new feature.

Can you resolve the merge conflict as well? Thanks.

@maltelenz maltelenz force-pushed the bugfix/reference-syntax branch from 06c8ba0 to f852a50 Compare January 22, 2024 13:26
@maltelenz
Copy link
Contributor Author

Well, this is can be seen as a doc-fix and not as a new feature.

The wiki page says: "no new PRs can be opened"

But if I was the project leader I would accept stuff like this regardless :)

Can you resolve the merge conflict as well? Thanks.

Done.

@beutlich beutlich changed the title Fix syntax errors in ModelicaReference documentation snippets. Fix syntax errors in ModelicaReference documentation snippets Jan 22, 2024
@beutlich beutlich added this to the MSL4.1.0 milestone Jan 26, 2024
@beutlich beutlich force-pushed the bugfix/reference-syntax branch from f852a50 to aae206b Compare January 27, 2024 11:06
@Harisankar-Allimangalath
Copy link
Contributor

@casella can you please review the changes .Thankyou

@AHaumer AHaumer merged commit bb72778 into modelica:master Feb 2, 2024
@beutlich beutlich removed the request for review from casella February 2, 2024 09:31
@beutlich beutlich removed this from the MSL4.1.0 milestone Feb 2, 2024
Harisankar-Allimangalath pushed a commit to Harisankar-Allimangalath/ModelicaStandardLibrary_1 that referenced this pull request Feb 2, 2024
Fix syntax errors in ModelicaReference documentation snippets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Issue addresses the documentation L: ModelicaReference Issue addresses ModelicaReference

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants