Skip to content

Correct start-value for t0 in ThreePhaseTwoLevel #4152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 10, 2024
Merged

Correct start-value for t0 in ThreePhaseTwoLevel #4152

merged 2 commits into from
Jan 10, 2024

Conversation

@HansOlsson
Copy link
Contributor

@HansOlsson HansOlsson commented Jun 13, 2023

Two improvements:

  • Better start-value for t0 - as it is a time fraction, not time. (This is mostly unimportant).
  • Change to time events, which slightly improves efficiency.

Closes #4054

@HansOlsson HansOlsson requested a review from AHaumer June 14, 2023 06:53
@HansOlsson HansOlsson changed the title Three phase two level t0 Correct start-value for t0 in ThreePhaseTwoLevel Jun 14, 2023
@beutlich beutlich added the L: Electrical.PowerConverters Issue addresses Modelica.Electrical.PowerConverters label Jul 2, 2023
@beutlich beutlich added this to the MSL4.1.0 milestone Aug 7, 2023
christiankral
christiankral approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@christiankral christiankral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@HansOlsson
Copy link
Contributor Author

HansOlsson commented Dec 15, 2023

@AHaumer Can you check it?

@HansOlsson
Copy link
Contributor Author

HansOlsson commented Jan 9, 2024

@AHaumer Can you check it?

Can we get more reviews of this - so that it can be merged before release-branch on Friday January 12th?

@casella casella self-requested a review January 9, 2024 22:21
casella
casella approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@casella casella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansOlsson HansOlsson force-pushed the ThreePhaseTwoLevel_t0 branch from cc085e4 to 917b0e2 Compare January 10, 2024 14:06
@HansOlsson HansOlsson merged commit 3e25b29 into modelica:master Jan 10, 2024
@HansOlsson HansOlsson deleted the ThreePhaseTwoLevel_t0 branch January 10, 2024 14:12
@beutlich beutlich removed the request for review from AHaumer January 10, 2024 19:11
@HansOlsson HansOlsson mentioned this pull request Mar 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christiankral christiankral christiankral approved these changes

@casella casella casella approved these changes

Assignees

No one assigned

Labels

L: Electrical.PowerConverters Issue addresses Modelica.Electrical.PowerConverters

Projects

None yet

Milestone

MSL4.1.0

Development

Successfully merging this pull request may close these issues.

Model issues detected by unit checking ThreePhaseTwoLevel_PWM

4 participants

@HansOlsson @christiankral @casella @beutlich