Fix unit error in SimpleAir #4096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
Author
|
@HansOlsson @casella Can one of you confirm that this is the direction we are going and approve the PR? |
Contributor
|
@qlambert-pro Simply add the suggested guys to reviewers. (They would remove themself when not relevant.) |
Contributor
Author
|
@tobolar I don't think I have the rights to do that, unfortunately. |
Contributor
|
In the original code, a kind of magic number was used! ;-) |
Contributor
Well, we had the constant on the line above - so it wasn't that magic. |
hubertus65
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The language design group has been trying to standardize the handling of units, so that literal values do not contribute to the unit of an expression in a way that would prevent further unit checking. We expect fixes similar to the one present in this PR to be necessary in the future.