Simplify selection of constraint equations to be used #3725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobolar
added
the
L: Mechanics.MultiBody
beutlich
reviewed
Jan 18, 2021
Member
beutlich
left a comment
beutlich
left a comment
There was a problem hiding this comment.
LGTM. Can you please address the other three constraints, too?
Contributor
Author
|
@beutlich Haven't realized this for the other constraints previously. Done now. Thanks. |
beutlich
force-pushed
the
prismaticConstraintSelection
branch
from
59a4e04 to
1df674c
Compare
Member
|
Thanks. I really wonder why there is no common base class for all four constaints as they share so much code. |
Contributor
Author
|
@beutlich Could you update your review? |
…ne, better understandable)
beutlich
force-pushed
the
prismaticConstraintSelection
branch
from
1df674c to
b9b8dff
Compare
beutlich
approved these changes
May 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Less error-prone and better understandable approach.