Skip to content

Fix security for logging in server #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
Merged

Fix security for logging in server #360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions ...k-server/src/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/server/ServerSession.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public open class ServerSession(
* @return The result of the ping request.
* @throws IllegalStateException If for some reason the method is not supported or the connection is closed.
*/
public suspend fun ping(): EmptyRequestResult = request<EmptyRequestResult>(PingRequest())
public suspend fun ping(): EmptyRequestResult = request(PingRequest())

/**
* Creates a message using the server's sampling capability.
Expand All @@ -121,8 +121,12 @@ public open class ServerSession(
params: CreateMessageRequest,
options: RequestOptions? = null,
): CreateMessageResult {
logger.debug { "Creating message with params: $params" }
return request<CreateMessageResult>(params, options)
logger.debug {
"Creating message with ${params.messages.size} messages, maxTokens=${params.maxTokens}, " +
"temperature=${params.temperature}, systemPrompt=${if (params.systemPrompt != null) "present" else "absent"}"
}
logger.trace { "Full createMessage params: $params" }
return request(params, options)
}

/**
Expand All @@ -138,15 +142,19 @@ public open class ServerSession(
options: RequestOptions? = null,
): ListRootsResult {
logger.debug { "Listing roots with params: $params" }
return request<ListRootsResult>(ListRootsRequest(params), options)
return request(ListRootsRequest(params), options)
}

public suspend fun createElicitation(
message: String,
requestedSchema: RequestedSchema,
options: RequestOptions? = null,
): CreateElicitationResult {
logger.debug { "Creating elicitation with message: $message" }
logger.debug {
"Creating elicitation with message length=${message.length}, " +
"schema properties count=${requestedSchema.properties.size}"
}
logger.trace { "Full elicitation message: $message, requestedSchema: $requestedSchema" }
return request(CreateElicitationRequest(message, requestedSchema), options)
}

Expand Down
Loading