Skip to content

Conversation

@bryanemmanuelbasor
Copy link

3621131: Add HSM Perceived Resolution APIs | https://android-review.googlesource.com/c/platform/frameworks/support/+/3621131

Motivation and Context

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@devcrocod devcrocod requested a review from Copilot October 28, 2025 09:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds HSM (Hardware Security Module) Perceived Resolution APIs to the Android frameworks support library, as referenced by the Android Gerrit change 3621131.

  • Introduces new HSM Perceived Resolution API functionality
  • Links to the corresponding Android review for detailed implementation changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -0,0 +1 @@
here3621131: Add HSM Perceived Resolution APIs | https://android-review.googlesource.com/c/platform/frameworks/support/+/3621131https://android-review.googlesource.com/c/platform/frameworks/support/+/3621131
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word 'here' appears to be accidentally included at the beginning of the line and should be removed. Additionally, the URL is duplicated at the end.

Suggested change
here3621131: Add HSM Perceived Resolution APIs | https://android-review.googlesource.com/c/platform/frameworks/support/+/3621131https://android-review.googlesource.com/c/platform/frameworks/support/+/3621131
3621131: Add HSM Perceived Resolution APIs | https://android-review.googlesource.com/c/platform/frameworks/support/+/3621131

Copilot uses AI. Check for mistakes.
@@ -0,0 +1 @@
here3621131: Add HSM Perceived Resolution APIs | https://android-review.googlesource.com/c/platform/frameworks/support/+/3621131https://android-review.googlesource.com/c/platform/frameworks/support/+/3621131
Copy link

Copilot AI Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL is duplicated at the end of the line. Remove the second occurrence of 'https://android-review.googlesource.com/c/platform/frameworks/support/+/3621131'.

Suggested change
here3621131: Add HSM Perceived Resolution APIs | https://android-review.googlesource.com/c/platform/frameworks/support/+/3621131https://android-review.googlesource.com/c/platform/frameworks/support/+/3621131
here3621131: Add HSM Perceived Resolution APIs | https://android-review.googlesource.com/c/platform/frameworks/support/+/3621131

Copilot uses AI. Check for mistakes.
@kpavlov kpavlov added the question Further information is requested label Nov 5, 2025
@kpavlov
Copy link
Contributor

kpavlov commented Nov 5, 2025

@bryanemmanuelbasor , could you please explain the reason of this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants