Wrap each request in a service scope#276
Merged
stephentoub merged 3 commits intomodelcontextprotocol:mainfrom Apr 11, 2025
Merged
Wrap each request in a service scope#276stephentoub merged 3 commits intomodelcontextprotocol:mainfrom
stephentoub merged 3 commits intomodelcontextprotocol:mainfrom
Conversation
halter73
approved these changes
Apr 11, 2025
Contributor
halter73
left a comment
halter73
left a comment
There was a problem hiding this comment.
It might also be interesting to do the same thing for client notification/sampling/roots handlers, but I agree the server is the most important.
stephentoub
force-pushed
the
scopedservices
branch
from
e0a9bda to
812e5f7
Compare
This was referenced Jul 24, 2025
jeffhandley
added
the
breaking-change
Contributor
|
Adding the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As long as I was touching the request handlers, I also made a change I've been meaning to make, which is to have all of these delegate callbacks return ValueTask instead of Task.
Fixes #234
Fixes #198