Propagate fix from AIFunctionFactory to TemporaryAIFunctionFactory#215
Merged
stephentoub merged 1 commit intomodelcontextprotocol:mainfrom Apr 5, 2025
Merged
Conversation
|
|
||
| // Resolve the contract used to marshal the value from JSON -- can throw if not supported or not found. | ||
| Type parameterType = parameter.ParameterType; | ||
| JsonTypeInfo typeInfo = serializerOptions.GetTypeInfo(parameterType); |
Member
There was a problem hiding this comment.
Pretty sure the same issue also manifested for return parameters. I take it you dropped the fix for that intentionally?
Contributor
Author
There was a problem hiding this comment.
That was a larger set of changes, it's much less of an issue (as opposed to parameters that are things like IMcpServer and CancellationToken that have no chance of being in the JSO), and this code will (hopefully) all be deleted tomorrow, so I chose to let it be. We can bring it over if you think it's worthwhile, though.
Member
There was a problem hiding this comment.
It's fine if we wait. I also decided against backporting the fix for the same reason.
This was referenced Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #214