-
Notifications
You must be signed in to change notification settings - Fork 677
Add serialization roundtrip tests for all Protocol namespace types #1289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4850d43
Initial plan
Copilot dfe5545
Add serialization round-trip tests for 10 protocol types
Copilot 791d1a6
Add serialization round-trip tests for protocol types
Copilot 521d61e
Add serialization round-trip tests for 10 Protocol types
Copilot 0f2afde
Add protocol type serialization round-trip tests
Copilot 785e21d
Add serialization round-trip tests for protocol types
Copilot a6299cf
Add serialization round-trip tests for notification params and capabi…
Copilot 76fbe3f
Refactor protocol test files: split tests into dedicated files
Copilot 7fcde12
Strengthen Assert.NotNull(deserialized.Meta) to validate actual content
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
43 changes: 43 additions & 0 deletions
43
tests/ModelContextProtocol.Tests/Protocol/AnnotationsTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| using ModelContextProtocol.Protocol; | ||
| using System.Text.Json; | ||
|
|
||
| namespace ModelContextProtocol.Tests.Protocol; | ||
|
|
||
| public static class AnnotationsTests | ||
| { | ||
| [Fact] | ||
| public static void Annotations_SerializationRoundTrip_PreservesAllProperties() | ||
| { | ||
| var original = new Annotations | ||
| { | ||
| Audience = [Role.User, Role.Assistant], | ||
| Priority = 0.75f, | ||
| LastModified = new DateTimeOffset(2025, 6, 15, 10, 30, 0, TimeSpan.Zero) | ||
| }; | ||
|
|
||
| string json = JsonSerializer.Serialize(original, McpJsonUtilities.DefaultOptions); | ||
| var deserialized = JsonSerializer.Deserialize<Annotations>(json, McpJsonUtilities.DefaultOptions); | ||
|
|
||
| Assert.NotNull(deserialized); | ||
| Assert.NotNull(deserialized.Audience); | ||
| Assert.Equal(2, deserialized.Audience.Count); | ||
| Assert.Equal(Role.User, deserialized.Audience[0]); | ||
| Assert.Equal(Role.Assistant, deserialized.Audience[1]); | ||
| Assert.Equal(original.Priority, deserialized.Priority); | ||
| Assert.Equal(original.LastModified, deserialized.LastModified); | ||
| } | ||
|
|
||
| [Fact] | ||
| public static void Annotations_SerializationRoundTrip_WithMinimalProperties() | ||
| { | ||
| var original = new Annotations(); | ||
|
|
||
| string json = JsonSerializer.Serialize(original, McpJsonUtilities.DefaultOptions); | ||
| var deserialized = JsonSerializer.Deserialize<Annotations>(json, McpJsonUtilities.DefaultOptions); | ||
|
|
||
| Assert.NotNull(deserialized); | ||
| Assert.Null(deserialized.Audience); | ||
| Assert.Null(deserialized.Priority); | ||
| Assert.Null(deserialized.LastModified); | ||
| } | ||
| } |
24 changes: 24 additions & 0 deletions
24
tests/ModelContextProtocol.Tests/Protocol/ArgumentTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| using ModelContextProtocol.Protocol; | ||
| using System.Text.Json; | ||
|
|
||
| namespace ModelContextProtocol.Tests.Protocol; | ||
|
|
||
| public static class ArgumentTests | ||
| { | ||
| [Fact] | ||
| public static void Argument_SerializationRoundTrip_PreservesAllProperties() | ||
| { | ||
| var original = new Argument | ||
| { | ||
| Name = "temperature", | ||
| Value = "72" | ||
| }; | ||
|
|
||
| string json = JsonSerializer.Serialize(original, McpJsonUtilities.DefaultOptions); | ||
| var deserialized = JsonSerializer.Deserialize<Argument>(json, McpJsonUtilities.DefaultOptions); | ||
|
|
||
| Assert.NotNull(deserialized); | ||
| Assert.Equal(original.Name, deserialized.Name); | ||
| Assert.Equal(original.Value, deserialized.Value); | ||
| } | ||
| } |
56 changes: 56 additions & 0 deletions
56
tests/ModelContextProtocol.Tests/Protocol/CallToolRequestParamsTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| using ModelContextProtocol.Protocol; | ||
| using System.Text.Json; | ||
| using System.Text.Json.Nodes; | ||
|
|
||
| namespace ModelContextProtocol.Tests.Protocol; | ||
|
|
||
| public static class CallToolRequestParamsTests | ||
| { | ||
| [Fact] | ||
| public static void CallToolRequestParams_SerializationRoundTrip_PreservesAllProperties() | ||
| { | ||
| var original = new CallToolRequestParams | ||
| { | ||
| Name = "get_weather", | ||
| Arguments = new Dictionary<string, JsonElement> | ||
| { | ||
| ["city"] = JsonDocument.Parse("\"Seattle\"").RootElement.Clone(), | ||
| ["units"] = JsonDocument.Parse("\"metric\"").RootElement.Clone() | ||
| }, | ||
| Task = new McpTaskMetadata { TimeToLive = TimeSpan.FromHours(1) }, | ||
| Meta = new JsonObject { ["progressToken"] = "token-123" } | ||
| }; | ||
|
|
||
| string json = JsonSerializer.Serialize(original, McpJsonUtilities.DefaultOptions); | ||
| var deserialized = JsonSerializer.Deserialize<CallToolRequestParams>(json, McpJsonUtilities.DefaultOptions); | ||
|
|
||
| Assert.NotNull(deserialized); | ||
| Assert.Equal(original.Name, deserialized.Name); | ||
| Assert.NotNull(deserialized.Arguments); | ||
| Assert.Equal(2, deserialized.Arguments.Count); | ||
| Assert.Equal("Seattle", deserialized.Arguments["city"].GetString()); | ||
| Assert.Equal("metric", deserialized.Arguments["units"].GetString()); | ||
| Assert.NotNull(deserialized.Task); | ||
| Assert.Equal(original.Task.TimeToLive, deserialized.Task.TimeToLive); | ||
| Assert.NotNull(deserialized.Meta); | ||
| Assert.Equal("token-123", (string)deserialized.Meta["progressToken"]!); | ||
| } | ||
|
|
||
| [Fact] | ||
| public static void CallToolRequestParams_SerializationRoundTrip_WithMinimalProperties() | ||
| { | ||
| var original = new CallToolRequestParams | ||
| { | ||
| Name = "simple_tool" | ||
| }; | ||
|
|
||
| string json = JsonSerializer.Serialize(original, McpJsonUtilities.DefaultOptions); | ||
| var deserialized = JsonSerializer.Deserialize<CallToolRequestParams>(json, McpJsonUtilities.DefaultOptions); | ||
|
|
||
| Assert.NotNull(deserialized); | ||
| Assert.Equal(original.Name, deserialized.Name); | ||
| Assert.Null(deserialized.Arguments); | ||
| Assert.Null(deserialized.Task); | ||
| Assert.Null(deserialized.Meta); | ||
| } | ||
| } | ||
58 changes: 58 additions & 0 deletions
58
tests/ModelContextProtocol.Tests/Protocol/CallToolResultTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| using ModelContextProtocol.Protocol; | ||
| using System.Text.Json; | ||
| using System.Text.Json.Nodes; | ||
|
|
||
| namespace ModelContextProtocol.Tests.Protocol; | ||
|
|
||
| public static class CallToolResultTests | ||
| { | ||
| [Fact] | ||
| public static void CallToolResult_SerializationRoundTrip_PreservesAllProperties() | ||
| { | ||
| var original = new CallToolResult | ||
| { | ||
| Content = [new TextContentBlock { Text = "Result text" }], | ||
| StructuredContent = JsonNode.Parse("""{"temperature":72}"""), | ||
| IsError = false, | ||
| Task = new McpTask | ||
| { | ||
| TaskId = "task-1", | ||
| Status = McpTaskStatus.Completed, | ||
| CreatedAt = new DateTimeOffset(2025, 1, 1, 0, 0, 0, TimeSpan.Zero), | ||
| LastUpdatedAt = new DateTimeOffset(2025, 1, 1, 0, 0, 0, TimeSpan.Zero) | ||
| }, | ||
| Meta = new JsonObject { ["key"] = "value" } | ||
| }; | ||
|
|
||
| string json = JsonSerializer.Serialize(original, McpJsonUtilities.DefaultOptions); | ||
| var deserialized = JsonSerializer.Deserialize<CallToolResult>(json, McpJsonUtilities.DefaultOptions); | ||
|
|
||
| Assert.NotNull(deserialized); | ||
| Assert.Single(deserialized.Content); | ||
| var textBlock = Assert.IsType<TextContentBlock>(deserialized.Content[0]); | ||
| Assert.Equal("Result text", textBlock.Text); | ||
| Assert.NotNull(deserialized.StructuredContent); | ||
| Assert.Equal(72, deserialized.StructuredContent["temperature"]!.GetValue<int>()); | ||
| Assert.False(deserialized.IsError); | ||
| Assert.NotNull(deserialized.Task); | ||
| Assert.Equal("task-1", deserialized.Task.TaskId); | ||
| Assert.NotNull(deserialized.Meta); | ||
| Assert.Equal("value", (string)deserialized.Meta["key"]!); | ||
| } | ||
|
|
||
| [Fact] | ||
| public static void CallToolResult_SerializationRoundTrip_WithMinimalProperties() | ||
| { | ||
| var original = new CallToolResult(); | ||
|
|
||
| string json = JsonSerializer.Serialize(original, McpJsonUtilities.DefaultOptions); | ||
| var deserialized = JsonSerializer.Deserialize<CallToolResult>(json, McpJsonUtilities.DefaultOptions); | ||
|
|
||
| Assert.NotNull(deserialized); | ||
| Assert.Empty(deserialized.Content); | ||
| Assert.Null(deserialized.StructuredContent); | ||
| Assert.Null(deserialized.IsError); | ||
| Assert.Null(deserialized.Task); | ||
| Assert.Null(deserialized.Meta); | ||
| } | ||
| } |
25 changes: 25 additions & 0 deletions
25
tests/ModelContextProtocol.Tests/Protocol/CancelMcpTaskRequestParamsTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| using ModelContextProtocol.Protocol; | ||
| using System.Text.Json; | ||
|
|
||
| namespace ModelContextProtocol.Tests.Protocol; | ||
|
|
||
| public static class CancelMcpTaskRequestParamsTests | ||
| { | ||
| [Fact] | ||
| public static void CancelMcpTaskRequestParams_SerializationRoundTrip() | ||
| { | ||
| // Arrange | ||
| var original = new CancelMcpTaskRequestParams | ||
| { | ||
| TaskId = "cancel-task-456" | ||
| }; | ||
|
|
||
| // Act | ||
| string json = JsonSerializer.Serialize(original, McpJsonUtilities.DefaultOptions); | ||
| var deserialized = JsonSerializer.Deserialize<CancelMcpTaskRequestParams>(json, McpJsonUtilities.DefaultOptions); | ||
|
|
||
| // Assert | ||
| Assert.NotNull(deserialized); | ||
| Assert.Equal(original.TaskId, deserialized.TaskId); | ||
| } | ||
| } |
33 changes: 33 additions & 0 deletions
33
tests/ModelContextProtocol.Tests/Protocol/CancelMcpTaskResultTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| using ModelContextProtocol.Protocol; | ||
| using System.Text.Json; | ||
|
|
||
| namespace ModelContextProtocol.Tests.Protocol; | ||
|
|
||
| public static class CancelMcpTaskResultTests | ||
| { | ||
| [Fact] | ||
| public static void CancelMcpTaskResult_SerializationRoundTrip() | ||
| { | ||
| // Arrange | ||
| var original = new CancelMcpTaskResult | ||
| { | ||
| TaskId = "cancelled-789", | ||
| Status = McpTaskStatus.Cancelled, | ||
| StatusMessage = "Cancelled by user", | ||
| CreatedAt = DateTimeOffset.UtcNow, | ||
| LastUpdatedAt = DateTimeOffset.UtcNow, | ||
| TimeToLive = null, | ||
| PollInterval = null | ||
| }; | ||
|
|
||
| // Act | ||
| string json = JsonSerializer.Serialize(original, McpJsonUtilities.DefaultOptions); | ||
| var deserialized = JsonSerializer.Deserialize<CancelMcpTaskResult>(json, McpJsonUtilities.DefaultOptions); | ||
|
|
||
| // Assert | ||
| Assert.NotNull(deserialized); | ||
| Assert.Equal(original.TaskId, deserialized.TaskId); | ||
| Assert.Equal(original.Status, deserialized.Status); | ||
| Assert.Equal(original.StatusMessage, deserialized.StatusMessage); | ||
| } | ||
| } |
45 changes: 45 additions & 0 deletions
45
tests/ModelContextProtocol.Tests/Protocol/CancelledNotificationParamsTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| using ModelContextProtocol.Protocol; | ||
| using System.Text.Json; | ||
| using System.Text.Json.Nodes; | ||
|
|
||
| namespace ModelContextProtocol.Tests.Protocol; | ||
|
|
||
| public static class CancelledNotificationParamsTests | ||
| { | ||
| [Fact] | ||
| public static void CancelledNotificationParams_SerializationRoundTrip_PreservesAllProperties() | ||
| { | ||
| var original = new CancelledNotificationParams | ||
| { | ||
| RequestId = new RequestId(42), | ||
| Reason = "User cancelled the operation", | ||
| Meta = new JsonObject { ["key"] = "value" } | ||
| }; | ||
|
|
||
| string json = JsonSerializer.Serialize(original, McpJsonUtilities.DefaultOptions); | ||
| var deserialized = JsonSerializer.Deserialize<CancelledNotificationParams>(json, McpJsonUtilities.DefaultOptions); | ||
|
|
||
| Assert.NotNull(deserialized); | ||
| Assert.Equal(original.RequestId, deserialized.RequestId); | ||
| Assert.Equal(original.Reason, deserialized.Reason); | ||
| Assert.NotNull(deserialized.Meta); | ||
| Assert.Equal("value", (string)deserialized.Meta["key"]!); | ||
| } | ||
|
|
||
| [Fact] | ||
| public static void CancelledNotificationParams_SerializationRoundTrip_WithMinimalProperties() | ||
| { | ||
| var original = new CancelledNotificationParams | ||
| { | ||
| RequestId = new RequestId("req-123") | ||
| }; | ||
|
|
||
| string json = JsonSerializer.Serialize(original, McpJsonUtilities.DefaultOptions); | ||
| var deserialized = JsonSerializer.Deserialize<CancelledNotificationParams>(json, McpJsonUtilities.DefaultOptions); | ||
|
|
||
| Assert.NotNull(deserialized); | ||
| Assert.Equal(original.RequestId, deserialized.RequestId); | ||
| Assert.Null(deserialized.Reason); | ||
| Assert.Null(deserialized.Meta); | ||
| } | ||
| } |
57 changes: 57 additions & 0 deletions
57
tests/ModelContextProtocol.Tests/Protocol/ClientCapabilitiesTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| using ModelContextProtocol.Protocol; | ||
| using System.Text.Json; | ||
|
|
||
| namespace ModelContextProtocol.Tests.Protocol; | ||
|
|
||
| public static class ClientCapabilitiesTests | ||
| { | ||
| [Fact] | ||
| public static void ClientCapabilities_SerializationRoundTrip_PreservesAllProperties() | ||
| { | ||
| var original = new ClientCapabilities | ||
| { | ||
| Roots = new RootsCapability { ListChanged = true }, | ||
| Sampling = new SamplingCapability | ||
| { | ||
| Context = new SamplingContextCapability(), | ||
| Tools = new SamplingToolsCapability() | ||
| }, | ||
| Elicitation = new ElicitationCapability | ||
| { | ||
| Form = new FormElicitationCapability(), | ||
| Url = new UrlElicitationCapability() | ||
| }, | ||
| Tasks = new McpTasksCapability() | ||
| }; | ||
|
|
||
| string json = JsonSerializer.Serialize(original, McpJsonUtilities.DefaultOptions); | ||
| var deserialized = JsonSerializer.Deserialize<ClientCapabilities>(json, McpJsonUtilities.DefaultOptions); | ||
|
|
||
| Assert.NotNull(deserialized); | ||
| Assert.NotNull(deserialized.Roots); | ||
| Assert.True(deserialized.Roots.ListChanged); | ||
| Assert.NotNull(deserialized.Sampling); | ||
| Assert.NotNull(deserialized.Sampling.Context); | ||
| Assert.NotNull(deserialized.Sampling.Tools); | ||
| Assert.NotNull(deserialized.Elicitation); | ||
| Assert.NotNull(deserialized.Elicitation.Form); | ||
| Assert.NotNull(deserialized.Elicitation.Url); | ||
| Assert.NotNull(deserialized.Tasks); | ||
| } | ||
|
|
||
| [Fact] | ||
| public static void ClientCapabilities_SerializationRoundTrip_WithMinimalProperties() | ||
| { | ||
| var original = new ClientCapabilities(); | ||
|
|
||
| string json = JsonSerializer.Serialize(original, McpJsonUtilities.DefaultOptions); | ||
| var deserialized = JsonSerializer.Deserialize<ClientCapabilities>(json, McpJsonUtilities.DefaultOptions); | ||
|
|
||
| Assert.NotNull(deserialized); | ||
| Assert.Null(deserialized.Experimental); | ||
| Assert.Null(deserialized.Roots); | ||
| Assert.Null(deserialized.Sampling); | ||
| Assert.Null(deserialized.Elicitation); | ||
| Assert.Null(deserialized.Tasks); | ||
| } | ||
| } |
41 changes: 41 additions & 0 deletions
41
tests/ModelContextProtocol.Tests/Protocol/CompleteContextTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| using ModelContextProtocol.Protocol; | ||
| using System.Text.Json; | ||
|
|
||
| namespace ModelContextProtocol.Tests.Protocol; | ||
|
|
||
| public static class CompleteContextTests | ||
| { | ||
| [Fact] | ||
| public static void CompleteContext_SerializationRoundTrip_PreservesAllProperties() | ||
| { | ||
| var original = new CompleteContext | ||
| { | ||
| Arguments = new Dictionary<string, string> | ||
| { | ||
| ["language"] = "en", | ||
| ["region"] = "us" | ||
| } | ||
| }; | ||
|
|
||
| string json = JsonSerializer.Serialize(original, McpJsonUtilities.DefaultOptions); | ||
| var deserialized = JsonSerializer.Deserialize<CompleteContext>(json, McpJsonUtilities.DefaultOptions); | ||
|
|
||
| Assert.NotNull(deserialized); | ||
| Assert.NotNull(deserialized.Arguments); | ||
| Assert.Equal(2, deserialized.Arguments.Count); | ||
| Assert.Equal("en", deserialized.Arguments["language"]); | ||
| Assert.Equal("us", deserialized.Arguments["region"]); | ||
| } | ||
|
|
||
| [Fact] | ||
| public static void CompleteContext_SerializationRoundTrip_WithMinimalProperties() | ||
| { | ||
| var original = new CompleteContext(); | ||
|
|
||
| string json = JsonSerializer.Serialize(original, McpJsonUtilities.DefaultOptions); | ||
| var deserialized = JsonSerializer.Deserialize<CompleteContext>(json, McpJsonUtilities.DefaultOptions); | ||
|
|
||
| Assert.NotNull(deserialized); | ||
| Assert.Null(deserialized.Arguments); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.