generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 135
Implement check for write_bytes
#3108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tautschnig
merged 5 commits into
model-checking:main
from
celinval:issue-2998-write-bytes
Apr 5, 2024
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3db32dd
Add support to `write_bytes` used in MaybeUninit
celinval ab298c7
Add another test
celinval 6eee16f
Merge branch 'main' into issue-2998-write-bytes
celinval 90cda48
Merge branch 'main' into issue-2998-write-bytes
tautschnig e62904e
Merge branch 'main' into issue-2998-write-bytes
tautschnig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| // Copyright Kani Contributors | ||
| // SPDX-License-Identifier: Apache-2.0 OR MIT | ||
| // kani-flags: -Z valid-value-checks | ||
| //! Check that Kani can identify UB when converting from a maybe uninit(). | ||
celinval marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| use std::mem::MaybeUninit; | ||
| use std::num::NonZeroI64; | ||
|
|
||
| #[kani::proof] | ||
| pub fn check_valid_zeroed() { | ||
| let maybe = MaybeUninit::zeroed(); | ||
| let val: u128 = unsafe { maybe.assume_init() }; | ||
| assert_eq!(val, 0); | ||
| } | ||
|
|
||
| #[kani::proof] | ||
| #[kani::should_panic] | ||
| pub fn check_invalid_zeroed() { | ||
| let maybe = MaybeUninit::zeroed(); | ||
| let _val: NonZeroI64 = unsafe { maybe.assume_init() }; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| // Copyright Kani Contributors | ||
| // SPDX-License-Identifier: Apache-2.0 OR MIT | ||
| // kani-flags: -Z valid-value-checks | ||
| //! Check that Kani can identify UB when using write_bytes for initializing a variable. | ||
| #![feature(core_intrinsics)] | ||
|
|
||
| #[kani::proof] | ||
| #[kani::should_panic] | ||
| pub fn check_invalid_write() { | ||
| let mut val = 'a'; | ||
| let ptr = &mut val as *mut char; | ||
| // Should fail given that we wrote invalid value to array of char. | ||
| unsafe { std::intrinsics::write_bytes(ptr, kani::any(), 1) }; | ||
| } | ||
|
|
||
| #[kani::proof] | ||
| pub fn check_valid_write() { | ||
| let mut val = 10u128; | ||
| let ptr = &mut val as *mut _; | ||
| unsafe { std::intrinsics::write_bytes(ptr, kani::any(), 1) }; | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.