Remove unneeded unwinds from unbounded benchmarks #2431
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
There are unreachable loops in the code snippet compiled from generator
resume. For example, in the goto program compiled from the benchmarkmoved_locals.rs:The jump-back instruction
GOTO 8is unreachable as it is afterASSUME 0 ≠ 0.However, such unreachable loops can actually be correctly handle by CBMC. So we can remove the unwinding numbers from the benchmarks modified in this PR.
Resolved issues:
Resolves #ISSUE-NUMBER
Related RFC:
Optional #ISSUE-NUMBER.
Call-outs:
Testing:
How is this change tested?
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.