Add PR-blocking performance regression run #2362
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karkhaz
force-pushed
the
kk-benchcomp-kani-perf
branch
8 times, most recently
from
e6cb57c to
22d4785
Compare
This commit adds a CI job that runs the `benchcomp` tool on the performance regression suite, comparing the HEAD of the pull request to the branch that the PR targets. The CI job fails if any performance benchmark is more than 10% slower when run using the HEAD version of Kani, or if any performance benchmark fails with the HEAD version while passing with the base.
karkhaz
force-pushed
the
kk-benchcomp-kani-perf
branch
from
22d4785 to
91b33e3
Compare
karkhaz
added a commit
to karkhaz/kani
that referenced
this pull request
Apr 14, 2023
This commit adds a CI job that runs the `benchcomp` tool on the performance regression suite, comparing the HEAD of the pull request to the branch that the PR targets. The CI job fails if any performance benchmark regresses when run using the HEAD version of Kani with respect to the 'base' branch. Regression is defined in the config file: * a 3x slowdown for benchmarks that take <1s * a 2x slowdown for benchmarks that take <30s * a 10% slowdown for other benchmarks or if any performance benchmark fails with the HEAD version while passing with the base. This fixes model-checking#2277.
karkhaz
added a commit
to karkhaz/kani
that referenced
this pull request
Apr 15, 2023
This commit adds a CI job that runs the `benchcomp` tool on the performance regression suite, comparing the HEAD of the pull request to the branch that the PR targets. The CI job fails if any performance benchmark regresses when run using the HEAD version of Kani with respect to the 'base' branch. Regression is defined as a regression in symex or solver time of 10% for any benchmark for which this value is >2s, or if any performance benchmark fails with the HEAD version while passing with the base. This fixes model-checking#2277.
karkhaz
added a commit
to karkhaz/kani
that referenced
this pull request
Apr 17, 2023
This commit adds a CI job that runs the `benchcomp` tool on the performance regression suite, comparing the HEAD of the pull request to the branch that the PR targets. The CI job fails if any performance benchmark regresses when run using the HEAD version of Kani with respect to the 'base' branch. Regression is defined as a regression in symex or solver time of 10% for any benchmark for which this value is >2s, or if any performance benchmark fails with the HEAD version while passing with the base. This fixes model-checking#2277.
karkhaz
added a commit
to karkhaz/kani
that referenced
this pull request
Apr 17, 2023
This commit adds a CI job that runs the `benchcomp` tool on the performance regression suite, comparing the HEAD of the pull request to the branch that the PR targets. The CI job fails if any performance benchmark regresses when run using the HEAD version of Kani with respect to the 'base' branch. Regression is defined as a regression in symex or solver time of 10% for any benchmark for which this value is >2s, or if any performance benchmark fails with the HEAD version while passing with the base. This fixes model-checking#2277.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a CI job that runs the
benchcomptool on theperformance regression suite, comparing the HEAD of the pull request to
the branch that the PR targets.
The CI job fails if any performance benchmark is more than 10% slower
when run using the HEAD version of Kani, or if any performance benchmark
fails with the HEAD version while passing with the base.
This fixes #2277.
Testing: [link to GitHub Action run]
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.