fix gradle badge generation#784
Conversation
|
let's merge #783 first |
mstachniuk
left a comment
mstachniuk
left a comment
There was a problem hiding this comment.
Please remove at least unused code
| @@ -17,11 +17,8 @@ public String getRepositoryBadge(String version, String publicationRepository, S | |||
| } | |||
|
|
|||
| private String gradlePluginPortalBadge(String version, String publicationRepository, String pluginName) { | |||
There was a problem hiding this comment.
Now pluginName is unused. So you can remove all usages and mark:
get/setPublicationPluginNameinAbstractReleaseNotesTaskget/setPublicationPluginNameinReleaseNotes
as deprecated.
I would remove it in the next MAJOR version.
Don't forget to bump the minor version of Shipkit to follow SemVer!
I'm working on Start shipping Javadoc #233 (it should be ready to review in 2 weeks), so we can merge this PR + my together (to bump minor only once and add new value for users).
There was a problem hiding this comment.
Ok, now I see ReleaseNotes are fixed in #785 but still more code should be removed in this PR.
There was a problem hiding this comment.
thank you, I will revisit the code and will remove not needed code.
|
|
||
| #### 2.1.3 | ||
| - 2019-02-23 - [2 commits](https://github.com/mockito/shipkit/compare/v2.1.2...v2.1.3) by [Marcin Stachniuk](https://github.com/mstachniuk) - published to [](https://plugins.gradle.org/plugin/org.shipkit.java/2.1.3) | ||
| - 2019-02-23 - [2 commits](https://github.com/mockito/shipkit/compare/v2.1.2...v2.1.3) by [Marcin Stachniuk](https://github.com/mstachniuk) - published to [](https://plugins.gradle.org/plugin/org.shipkit.java/2.1.3) |
There was a problem hiding this comment.
Minor. It would be nice to fix all badges for all versions. Btw. 2.1.4, 2.1.2, 2.1.1 didn't exist - error during deployment.
There was a problem hiding this comment.
thx, yes, I will do so.
mstachniuk
left a comment
mstachniuk
left a comment
There was a problem hiding this comment.
👍 Thanks for fixing that (this bug was my fault)! Next time I need to be faster.
2 participants
fixes #774
now generates badges like
I've already adjusted the badges of the last two releases in docs/release-notes.md