Skip to content

Conversation

@tschuchortdev
Copy link

Adds some additional matchers like not, or leq. I couldn't be bothered to write tests because the code is so incredibly simple.

Base automatically changed from 2.x to main January 18, 2021 03:46
@perkss
Copy link

perkss commented Mar 2, 2022

Any plans to put this in?

@TWiStErRob
Copy link
Contributor

@tschuchortdev the code is simple, but it's still code, and the tests would protect it from breaking in the future. For example, if the functions get reordered, and accidentally change bodies or something we don't know yet. Verifying a basic requirement that the function delegates to the right one (by validating what it does e.g. tests would be different for lt and leq).

@lgladysz
Copy link

I think this is already merged in #508

@TWiStErRob
Copy link
Contributor

agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants