Skip to content

Conversation

@JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jun 27, 2025

PR Checklist

Overview

Bumps Knip, then removes all unused devDependencies and unnecessary config entries. Does not remove worker.js, ref #5389

Unused files (1)
lib/nodejs/worker.js  
Unused devDependencies (1)
webpack-cli  package.json:176:6
Configuration hints (5)
Remove from ignoreDependencies: karma-chrome-launcher
Remove from ignoreDependencies: karma-mocha-reporter
Remove from ignoreDependencies: karma-mocha
Remove from ignoreDependencies: karma-sauce-launcher
Remove from ignoreDependencies: prettier

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review June 30, 2025 23:37
@mark-wiemer
Copy link
Member

Updated description as this doesn't remove worker.js per #5389 . I don't want us to remove worker.js :D approved

@mark-wiemer mark-wiemer self-requested a review July 12, 2025 00:37
@JoshuaKGoldberg
Copy link
Member Author

The CI test failures are unrelated.

@JoshuaKGoldberg JoshuaKGoldberg merged commit f3d7430 into mochajs:main Jul 24, 2025
144 of 147 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the knip-5.61 branch July 24, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🛠 Repo: Unused files ignoreDependencies reported by Knip

2 participants