fix: remove :is() from mocha.css to support older browsers (#5225)
#5227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
approved these changes
Oct 13, 2024
Member
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
👍 Eventually it'd be nice to use more modern tooling that transpiles down to a supported browser range. But this makes sense in the interim. Thanks!
JoshuaKGoldberg
changed the title
:is() from mocha.css to support older browsers (#5225):is() from mocha.css to support older browsers (#5225)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
mocha.csscontains:is()and broke in older browsers #5225status: accepting prsOverview
Remove
:isto prevent CSS breaking in older browsers.This is also more consistent with older existent CSS which did not use
:is()in the same file, such as L318-L319.