Skip to content

feat: allow using any 3.x chokidar dependencies #5143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2024
Merged

feat: allow using any 3.x chokidar dependencies #5143

merged 1 commit into from
May 24, 2024

Conversation

@simhnna
Copy link
Contributor

@simhnna simhnna commented May 16, 2024 •
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

Compatibility with newer @types/node releases for typescript users

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 16, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: simhnna / name: Simon Hanna (03934ab)

legobeat
legobeat reviewed May 21, 2024
View reviewed changes
@simhnna simhnna requested a review from legobeat May 23, 2024 09:06
JoshuaKGoldberg
JoshuaKGoldberg requested changes May 24, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Up for switching to ^ and having this target the chokidar part of #5114?

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author waiting on response from OP or other posters - more information needed label May 24, 2024
@simhnna simhnna changed the title chore: bump chokidar to ^3.6.0 chore: allow using any 3.x chokidar dependencies May 24, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the title chore: allow using any 3.x chokidar dependencies feat: allow using any 3.x chokidar dependencies May 24, 2024
@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for author waiting on response from OP or other posters - more information needed label May 24, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-requested a review May 24, 2024 12:56
JoshuaKGoldberg
JoshuaKGoldberg approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks!

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented May 24, 2024

I also tried an npm upgrade chokidar locally and re-running tests and such. They all worked. ✔️

@JoshuaKGoldberg JoshuaKGoldberg merged commit 472a8be into mochajs:master May 24, 2024
@coveralls
Copy link

coveralls commented May 24, 2024

Coverage Status

coverage: 94.358%. remained the same
when pulling 03934ab on simhnna:bump-chokidar
into 99601da on mochajs:master.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request May 31, 2024
Closed
@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Jun 24, 2024

This was released in [email protected]. 🚀

@Grizzelbee Grizzelbee mentioned this pull request Jul 16, 2024
Closed
@hoang3402 hoang3402 mentioned this pull request Jul 16, 2024
Closed
@tylerezimmerman tylerezimmerman mentioned this pull request Jul 16, 2024
Merged
@tdbaine tdbaine mentioned this pull request Jul 16, 2024
Open
@M0ng00se7169 M0ng00se7169 mentioned this pull request Jul 16, 2024
Open
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 16, 2024
Merged
@MaxMood96 MaxMood96 mentioned this pull request Jul 17, 2024
Closed
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 17, 2024
Merged
@Grizzelbee Grizzelbee mentioned this pull request Jul 18, 2024
Closed
@SpinningRecords SpinningRecords mentioned this pull request Jul 20, 2024
Open
@saileshvyas saileshvyas mentioned this pull request Jul 27, 2024
Open
@hashim21223445 hashim21223445 mentioned this pull request Jul 28, 2024
Closed
@hashim21223445 hashim21223445 mentioned this pull request Jul 28, 2024
Merged
@abdulrahman305 abdulrahman305 mentioned this pull request Jul 28, 2024
Merged
@hashim21223445 hashim21223445 mentioned this pull request Jul 29, 2024
Merged
@hashim21223445 hashim21223445 mentioned this pull request Aug 7, 2024
Merged
@abdulrahman305 abdulrahman305 mentioned this pull request Aug 10, 2024
Merged
This was referenced Aug 11, 2024
Merged
Merged
@abdulrahman305 abdulrahman305 mentioned this pull request Aug 13, 2024
Closed
@MaxMood96 MaxMood96 mentioned this pull request Aug 25, 2024
Closed
@SapiannykSerhii SapiannykSerhii mentioned this pull request Sep 25, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request Oct 6, 2024
Closed
This was referenced Oct 23, 2024
Open
Open
@abdulrahman305 abdulrahman305 mentioned this pull request Oct 27, 2024
Closed
@HaLaGu1L HaLaGu1L mentioned this pull request Nov 1, 2024
Open
@SkyeFull90 SkyeFull90 mentioned this pull request Nov 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@legobeat legobeat Awaiting requested review from legobeat

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@simhnna @JoshuaKGoldberg @coveralls @legobeat