Skip to content

chore: fix header generation and production build crashes #5100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 27, 2024
Merged

chore: fix header generation and production build crashes #5100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
81bbd91
chore: use direct path to assetgraph-builder > buildProduction in nps
JoshuaKGoldberg Feb 24, 2024
e6999ae
chore: switch NODE_VERSION to 20
JoshuaKGoldberg Feb 24, 2024
a749668
chore: remove scripts/netlify-headers.js
JoshuaKGoldberg Feb 24, 2024
4533aae
chore: remove scripts/netlify-headers.js
JoshuaKGoldberg Feb 24, 2024
a37267a
Merge branch 'canary' into node-bin-build-production
JoshuaKGoldberg Feb 24, 2024
638da23
git checkout master -- netlify.toml
JoshuaKGoldberg Feb 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-scripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ module.exports = {
docs: {
default: {
script:
'nps docs.clean && nps docs.api && eleventy && nps docs.linkcheck && node scripts/netlify-headers.js docs/_site >> docs/_site/_headers',
'nps docs.clean && nps docs.api && eleventy && nps docs.linkcheck',
description: 'Build documentation'
},
production: {
Expand All @@ -277,7 +277,7 @@ module.exports = {
},
postbuild: {
script:
'buildProduction docs/_site/index.html --outroot docs/_dist --canonicalroot https://mochajs.org/ --optimizeimages --svgo --inlinehtmlimage 9400 --inlinehtmlscript 0 --asyncscripts && cp docs/_headers docs/_dist/_headers && node scripts/netlify-headers.js docs/_dist >> docs/_dist/_headers',
'node node_modules/assetgraph-builder/bin/buildProduction docs/_site/index.html --outroot docs/_dist --canonicalroot https://mochajs.org/ --optimizeimages --svgo --inlinehtmlimage 9400 --inlinehtmlscript 0 --asyncscripts && cp docs/_headers docs/_dist/_headers',
description: 'Post-process docs after build',
hiddenFromHelp: true
},
Expand Down
126 changes: 0 additions & 126 deletions scripts/netlify-headers.js
View file
Open in desktop

This file was deleted.