Skip to content

Conversation

@outsideris
Copy link
Contributor

Description of the Change

Remove unused 3 dependencies.

  • configstore
    • It introduced in 2137163 . But It appears to have been added by mistake from the beginning.
  • through2
    • It was introduced in a81e555 7 years ago for browserify. But I couldn't find where to use it in this commit.
    • It looks like removed in this commit when we drop the browserify.
  • watchify
    • It was introduced at c04c1d7 . But I couldn't find where to use it in this commit.
    • This is for browserify. Now we don't use browserify anymore.

@outsideris outsideris requested a review from juergba November 27, 2022 08:50
@juergba
Copy link
Contributor

juergba commented Nov 27, 2022

@outsideris there is a watch script in package-scripts.js, I suppose it uses watchify for its purpose. I don't think anybody has ever used that script, so could certainly be removed.

@outsideris
Copy link
Contributor Author

@juergba Did you mean here? I think docs.watch doesn't use watchify.

Copy link
Contributor

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outsideris thank you

@juergba juergba added type: chore generally involving deps, tooling, configuration, etc. semver-patch implementation requires increase of "patch" version number; "bug fixes" run-browser-test run browser tests on forked PR if code is safe labels Nov 29, 2022
@github-actions github-actions bot removed the run-browser-test run browser tests on forked PR if code is safe label Nov 29, 2022
@juergba juergba merged commit fc4ac58 into mochajs:master Nov 29, 2022
@juergba juergba added this to the next milestone Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-patch implementation requires increase of "patch" version number; "bug fixes" type: chore generally involving deps, tooling, configuration, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants